frankgh commented on code in PR #198:
URL: https://github.com/apache/cassandra-sidecar/pull/198#discussion_r1964011622
##########
server/src/main/java/org/apache/cassandra/sidecar/server/MainModule.java:
##########
@@ -598,6 +600,14 @@ public Router vertxRouter(Vertx vertx,
.handler(streamCdcSegmentHandler)
.build();
+ // Schema Reporting
+ protectedRouteBuilderFactory.get()
+ .router(router)
+ .method(HttpMethod.GET)
Review Comment:
The verb should not be GET. This should either be PUT or POST:
- PUT is more suitable for idempotent operations
- POST is more suitable for operations that are not idempotent
Also, this endpoint might be suitable for the operations framework.
Something to consider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
