sarankk commented on code in PR #198:
URL: https://github.com/apache/cassandra-sidecar/pull/198#discussion_r1964164599
##########
server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/BasicPermissions.java:
##########
@@ -63,6 +63,9 @@ public class BasicPermissions
public static final Permission READ_OPERATIONAL_JOB = new
DomainAwarePermission("OPERATIONAL_JOB:READ", OPERATION_SCOPE);
public static final Permission DECOMMISSION_NODE = new
DomainAwarePermission("NODE:DECOMMISSION", OPERATION_SCOPE);
+ // Permissions related to Schema Reporting
+ public static final Permission REPORT_SCHEMA = new
DomainAwarePermission("SCHEMA:REPORT", CLUSTER_SCOPE);
Review Comment:
I feel having 2 different permissions is better in general, with 1 granting
read permission automatically grants them report permission. But in this
particular case, since we already have a periodic task to report schema,
irrespective of this endpoint, we can use the `enable` flag for schema
reporting to control whether we want to allow reporting or not without adding a
separate permission for reporting control?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
