dcapwell commented on code in PR #3967:
URL: https://github.com/apache/cassandra/pull/3967#discussion_r1991823366


##########
src/java/org/apache/cassandra/db/SerializationHeader.java:
##########
@@ -384,6 +386,97 @@ public EncodingStats getEncodingStats()
         }
     }
 
+    public interface ParameterizedSerializer<P>

Review Comment:
   can we get serde tests for these new serializers?  been adding them to other 
serializers in https://github.com/apache/cassandra/pull/3954/ and keep finding 
bugs, so would be good to get the tests in with the new code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to