belliottsmith commented on code in PR #3967:
URL: https://github.com/apache/cassandra/pull/3967#discussion_r1992199429
##########
src/java/org/apache/cassandra/schema/SchemaKeyspace.java:
##########
@@ -140,6 +140,7 @@ private SchemaKeyspace()
+ "clustering_order text,"
+ "column_name_bytes blob,"
+ "kind text,"
+ + "unique_id int,"
Review Comment:
Ok, if this is for compatibility I’ll revert in my next patch.
This conversation highlighted for me an edge case to consider though, which
is that the epoch on which we assign these ids needs to be consistent across
the cluster. I doubt this will be the only time this happens, and I wonder if
TCM might want to add a schema-update facility for these kinds of upgrades to
make sure they’re consistent?
I don’t think this will be a major issue initially so we have time to think
about it, and perhaps I can do something one off for accord if we think TCM
won’t need it in future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
