dcapwell commented on code in PR #4013:
URL: https://github.com/apache/cassandra/pull/4013#discussion_r2023847132
##########
src/java/org/apache/cassandra/utils/FastByteOperations.java:
##########
@@ -269,16 +276,26 @@ public void copy(ByteBuffer srcBuf, int srcPosition,
ByteBuffer trgBuf, int trgP
{
Object src;
long srcOffset;
+
+ // Heap ByteBuffer (Mutable)
if (srcBuf.hasArray())
{
src = srcBuf.array();
srcOffset = BYTE_ARRAY_BASE_OFFSET + srcBuf.arrayOffset();
}
+ // Read-Only Heap ByteBuffer (Still has hb but read-only)
Review Comment:
can you add these comments to all code paths modified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
