dcapwell commented on code in PR #4013:
URL: https://github.com/apache/cassandra/pull/4013#discussion_r2226413341
##########
src/java/org/apache/cassandra/utils/FastByteOperations.java:
##########
@@ -326,16 +350,26 @@ public static int compareTo(ByteBuffer buffer1,
ByteBuffer buffer2)
Object obj1;
long offset1;
int length1;
+
+ // Heap ByteBuffer (Mutable)
if (buffer1.hasArray())
{
obj1 = buffer1.array();
offset1 = BYTE_ARRAY_BASE_OFFSET + buffer1.arrayOffset();
}
+ // Read-Only Heap ByteBuffer (Still has hb but read-only)
+ else if (buffer1.isReadOnly() && !buffer1.isDirect())
Review Comment:
can we make this the 3rd position
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
