aratno commented on code in PR #2033:
URL:
https://github.com/apache/cassandra-java-driver/pull/2033#discussion_r2035868413
##########
pom.xml:
##########
@@ -575,7 +575,7 @@
</analysisConfiguration>
<oldArtifacts>
<!-- The previous release used DataStax groupId, remove this
after the next release -->
-
<artifact>com.datastax.oss:${project.artifactId}:RELEASE</artifact>
+
<artifact>org.apache.cassandra:${project.artifactId}:RELEASE</artifact>
Review Comment:
Could use `${project.groupId}` here.
I still get a ton of failures locally, even with `s/RELEASE/4.19.0`, or
`4.18.0`, or `4.18.1`, but that's out of scope for this PR.
I wanted to set `failOnUnresolvedArtifacts=true` here as well, but that
would fail since `-parent` doesn't publish a JAR. It would be ideal to not
check `-parent`, and fail the pipeline if, for example, `-core` couldn't be
resolved.
The revapi check runs before the snapshot is built (on `verify`), so every
run compares against the last-published snapshot. I think we should move this
check to happen after snapshot publish. I'd still like this check to happen as
part of a PR, but it seems like the most direct route for that is an additional
local file repository we can install into, and do a local snapshot install (not
publish) then `revapi:check` before we pass the PR check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
