absurdfarce commented on code in PR #2033:
URL:
https://github.com/apache/cassandra-java-driver/pull/2033#discussion_r2036337432
##########
pom.xml:
##########
@@ -575,7 +575,7 @@
</analysisConfiguration>
<oldArtifacts>
<!-- The previous release used DataStax groupId, remove this
after the next release -->
-
<artifact>com.datastax.oss:${project.artifactId}:RELEASE</artifact>
+
<artifact>org.apache.cassandra:${project.artifactId}:RELEASE</artifact>
Review Comment:
Hmmmm, that doesn't seem to match up to what I'm seeing. If I run a "mvn
clean verify -DskipTests=true" on the branch of this PR I see the following:
```
[INFO] --------------< org.apache.cassandra:java-driver-parent
>---------------
[INFO] Building Apache Cassandra Java Driver 4.19.1-SNAPSHOT
[1/17]
[INFO] from pom.xml
…
[INFO] --- revapi:0.10.5:check (default) @ java-driver-core ---
Downloading from artifactory:
https://repo.aws.dsinternal.org/artifactory/dse/org/apache/cassandra/java-driver-core/maven-metadata.xml
Downloading from apache.snapshots:
https://repository.apache.org/snapshots/org/apache/cassandra/java-driver-core/maven-metadata.xml
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/cassandra/java-driver-core/maven-metadata.xml
Downloading from jboss:
https://repository.jboss.org/nexus/content/groups/public/org/apache/cassandra/java-driver-core/maven-metadata.xml
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/cassandra/java-driver-core/maven-metadata.xml
(410 B at 621 B/s)
Downloaded from artifactory:
https://repo.aws.dsinternal.org/artifactory/dse/org/apache/cassandra/java-driver-core/maven-metadata.xml
(410 B at 74 B/s)
[INFO] Comparing [org.apache.cassandra:java-driver-core:jar:4.19.0] against
[org.apache.cassandra:java-driver-core:jar:4.19.1-SNAPSHOT] (including their
transitive dependencies).
[INFO] API checks completed without failures.
```
That's what I would expect given my understanding of what revapi does; it's
goal is to compare exposed APIs of the prior version to the one you're working
on to check for bogus changes. For 4.19.1-SNAPSHOT I would expect that to
compare to 4.19.0... and the log above sure seems to indicate that's what's
happening.
I'll readily stipulate that I am far from a Maven expert... that's just what
it looks like to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
