dcapwell commented on code in PR #4078:
URL: https://github.com/apache/cassandra/pull/4078#discussion_r2040329282


##########
src/java/org/apache/cassandra/db/partitions/PartitionUpdate.java:
##########
@@ -810,6 +814,19 @@ public void serialize(PartitionUpdate update, 
DataOutputPlus out, int version) t
             }
         }
 
+        public void serializeWithoutKey(PartitionUpdate update, TableMetadatas 
tables, DataOutputPlus out, int version) throws IOException
+        {
+            try (UnfilteredRowIterator iter = update.unfilteredIterator())
+            {
+                assert !iter.isReverseOrder();

Review Comment:
   no issues for me, but is this possible?  `update.unfilteredIterator()` is 
explicitly not reversed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to