dcapwell commented on code in PR #4078:
URL: https://github.com/apache/cassandra/pull/4078#discussion_r2040332193
##########
src/java/org/apache/cassandra/schema/TableMetadata.java:
##########
@@ -770,6 +770,18 @@ public static TableMetadata minimal(String keyspace,
String name)
.build();
}
+ /**
+ * There is a couple of places in the code where we need a TableMetadata
object and don't have one readily available
+ * and know that only the keyspace and name matter. This creates such
"fake" metadata. Use only if you know what
+ * you're doing.
+ */
+ public static TableMetadata minimal(String keyspace, String name, TableId
tableId)
Review Comment:
this is used in
`test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java`, can we
mark this for tests?
```suggestion
@VisibleForTesting
public static TableMetadata minimal(String keyspace, String name,
TableId tableId)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
