dcapwell commented on code in PR #4078:
URL: https://github.com/apache/cassandra/pull/4078#discussion_r2040366312
##########
test/unit/org/apache/cassandra/utils/CassandraGenerators.java:
##########
@@ -1224,7 +1225,7 @@ private static ColumnMetadata
createColumnDefinition(String ks, String table,
// empty type is also not supported, so filter out
case PARTITION_KEY:
case CLUSTERING:
- typeGen = Generators.filter(typeGen, t -> t !=
EmptyType.instance).map(AbstractType::freeze);
+ typeGen = Generators.filter(typeGen, t -> t !=
EmptyType.instance && t !=
CounterColumnType.instance).map(AbstractType::freeze);
Review Comment:
primary columns can't be counter columns; what motivated this change?
##########
test/unit/org/apache/cassandra/utils/CassandraGenerators.java:
##########
@@ -1224,7 +1225,7 @@ private static ColumnMetadata
createColumnDefinition(String ks, String table,
// empty type is also not supported, so filter out
case PARTITION_KEY:
case CLUSTERING:
- typeGen = Generators.filter(typeGen, t -> t !=
EmptyType.instance).map(AbstractType::freeze);
+ typeGen = Generators.filter(typeGen, t -> t !=
EmptyType.instance && t !=
CounterColumnType.instance).map(AbstractType::freeze);
Review Comment:
primary columns can't be counter columns; what motivated this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
