smiklosovic commented on code in PR #4115:
URL: https://github.com/apache/cassandra/pull/4115#discussion_r2058616235


##########
src/antlr/Parser.g:
##########
@@ -982,9 +982,30 @@ columnConstraints returns [ColumnConstraints.Raw 
constraints]
     ;
 
 columnConstraint returns [ColumnConstraint columnConstraint]
-    : funcName=ident '(' k=ident ')' op=relationType t=value { 
$columnConstraint = new FunctionColumnConstraint.Raw(funcName, k, op, 
t.getText()).prepare(); }
-    | funcName=ident '(' k=ident ')' { $columnConstraint = new 
UnaryFunctionColumnConstraint.Raw(funcName, k).prepare(); }
-    | k=ident op=relationType t=value { $columnConstraint = new 
ScalarColumnConstraint.Raw(k, op, t.getText()).prepare(); }
+    @init { List<String> arguments = new ArrayList<>(); }

Review Comment:
   this will enable:
   
   `NOT NULL` special treatment for not null
   `JSON` unary
   `SOMECONSTRAINT('x', ...)` (function)
   `SOMECONSTRAINT('x') > 5` (function with relation and term)
   `val int check val > 5` (scalar)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to