smiklosovic commented on code in PR #4115:
URL: https://github.com/apache/cassandra/pull/4115#discussion_r2058630060
##########
src/java/org/apache/cassandra/cql3/constraints/FunctionColumnConstraint.java:
##########
@@ -187,7 +188,12 @@ public static class Serializer implements
MetadataSerializer<FunctionColumnConst
public void serialize(FunctionColumnConstraint columnConstraint,
DataOutputPlus out, Version version) throws IOException
{
out.writeUTF(columnConstraint.function.name);
- out.writeUTF(columnConstraint.columnName.toCQLString());
Review Comment:
we actually do not need to serialize column name, why would we want to do
that? This way, serialized constraint does not know anything about what column
it was specified on. We do not need to know that upon de/ser, we set column in
ColumnMetadata constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
