ifesdjeen commented on code in PR #4165:
URL: https://github.com/apache/cassandra/pull/4165#discussion_r2104719131
##########
test/distributed/org/apache/cassandra/service/accord/AccordJournalBurnTest.java:
##########
@@ -308,6 +314,13 @@ public void replay(CommandStores commandStores)
this.closeCurrentSegmentForTestingIfNonEmpty();
super.replay(commandStores);
}
+
+ @Override
+ public PersistentField.Persister<DurableBefore,
DurableBefore> durableBeforePersister()
+ {
+ // TODO (required): we should be persisting
in the journal, but this currently causes the burn test to take far too long
Review Comment:
I've pushed a variant that that might work (synchronous, but then switch to
periodic):
https://github.com/ifesdjeen/cassandra/commit/ec3a5a593e1a110179884449a726faac68fa37ff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
