belliottsmith commented on code in PR #4200:
URL: https://github.com/apache/cassandra/pull/4200#discussion_r2149623341
##########
test/distributed/org/apache/cassandra/distributed/test/accord/AccordLoadTest.java:
##########
@@ -141,32 +142,42 @@ public boolean matches(int i, int i1, IMessage iMessage)
{
inFlight.acquire();
rateLimiter.acquire();
- long commandStart = System.nanoTime();
- int k = random.nextInt(keyCount);
- if (random.nextFloat() < readChance)
+ try
{
- coordinator.executeWithResult((success, fail) -> {
- inFlight.release();
- if (fail == null)
histogram.add(NANOSECONDS.toMicros(System.nanoTime() - commandStart));
- // else
exceptions.add(fail);
- }, "SELECT * FROM " + qualifiedAccordTableName + "
WHERE k = ?;", ConsistencyLevel.SERIAL, k);
- }
- else if (initialised.get(k))
- {
- coordinator.executeWithResult((success, fail) -> {
- inFlight.release();
- if (fail == null)
histogram.add(NANOSECONDS.toMicros(System.nanoTime() - commandStart));
- // else
exceptions.add(fail);
- }, "UPDATE " + qualifiedAccordTableName + " SET v += 1
WHERE k = ? IF EXISTS;", ConsistencyLevel.SERIAL, ConsistencyLevel.QUORUM, k);
+ long commandStart = System.nanoTime();
+ int k = random.nextInt(keyCount);
+ if (random.nextFloat() < readChance)
+ {
+ coordinator.executeWithResult((success, fail) -> {
+ inFlight.release();
+ if (fail == null)
histogram.add(NANOSECONDS.toMicros(System.nanoTime() - commandStart));
+ // else
exceptions.add(fail);
Review Comment:
I think that's been commented for a while, probably because it's sort of
expected some queries fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
