belliottsmith commented on code in PR #222:
URL: https://github.com/apache/cassandra-accord/pull/222#discussion_r2211546233
##########
accord-core/src/main/java/accord/local/PreLoadContext.java:
##########
@@ -111,12 +114,14 @@ default boolean isSubsetOf(PreLoadContext superset)
Unseekables<?> keys = keys();
if (!keys.isEmpty())
{
- KeyHistory requiredHistory = keyHistory();
+ LoadKeys requiredHistory = loadKeys();
Review Comment:
Well, it's when you can expect the keys to be loaded. I could call it
LoadKeysMode, but e.g. LoadKeys.ASYNC seems pretty clear, and I'm not sure
LoadKeysMode.ASYNC is much better. Open to suggestions for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
