belliottsmith commented on code in PR #222:
URL: https://github.com/apache/cassandra-accord/pull/222#discussion_r2211548980
##########
accord-core/src/main/java/accord/local/PreLoadContext.java:
##########
@@ -91,15 +93,16 @@ default void forEachId(Consumer<TxnId> consumer)
*/
default Unseekables<?> keys() { return RoutingKeys.EMPTY; }
- default KeyHistory keyHistory() { return NONE; }
+ default LoadKeys loadKeys() { return NONE; }
+ default LoadKeysFor loadKeysFor() { return WRITE; }
Review Comment:
I don't know. I am inclined to keep it as is, because we have a LOT of these
classes and most don't need to load key information. But I don't feel
incredibly strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
