belliottsmith commented on code in PR #237:
URL: https://github.com/apache/cassandra-accord/pull/237#discussion_r2270065330
##########
accord-core/src/main/java/accord/local/RedundantBefore.java:
##########
@@ -360,7 +366,7 @@ private static Timestamp
maybeClearStaleUntilAtLeast(Timestamp staleUntilAtLeast
public Bounds with(TxnId newBound, SomeStatus addStatus)
{
// TODO (desired): introduce special-cased faster merge for adding
a single value
- return merge(range, this, new Bounds(range, Long.MIN_VALUE,
Long.MAX_VALUE, new TxnId[] { newBound }, new short[] { addStatus.encoded },
null));
+ return merge(range, this, new Bounds(range, Long.MIN_VALUE,
Long.MAX_VALUE, new TxnId[] { newBound }, new short[] {
(short)addStatus.encoded }, null));
Review Comment:
masking to the range of the down-casted type is a no-op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
