ifesdjeen commented on code in PR #237:
URL: https://github.com/apache/cassandra-accord/pull/237#discussion_r2270239012


##########
accord-core/src/main/java/accord/topology/Topologies.java:
##########
@@ -88,9 +88,16 @@ default boolean isEmpty()
      */
     SortedArrayList<Id> nodes();
 
-    default SortedArrayList<Id> staleNodes()
+    default SortedArrayList<Id> staleOrRemovedIds()

Review Comment:
   Won't this break if we have a node that got removed but then re-added?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to