dcapwell commented on code in PR #4322:
URL: https://github.com/apache/cassandra/pull/4322#discussion_r2283253172
##########
src/java/org/apache/cassandra/service/accord/txn/AccordUpdateParameters.java:
##########
@@ -82,7 +82,7 @@ public UpdateParameters updateParameters(TableMetadata
metadata, DecoratedKey dk
return new RowUpdateParameters(metadata,
disabledGuardrails,
options,
- timestamp,
+ overrideTimestamp ==
TxnWrite.NO_TIMESTAMP ? timestamp : overrideTimestamp,
Review Comment:
i *think* this is for https://github.com/apache/cassandra/pull/4299 but kept
here as its part of a serialization change.
##########
src/java/org/apache/cassandra/service/accord/txn/AccordUpdateParameters.java:
##########
@@ -82,7 +82,7 @@ public UpdateParameters updateParameters(TableMetadata
metadata, DecoratedKey dk
return new RowUpdateParameters(metadata,
disabledGuardrails,
options,
- timestamp,
+ overrideTimestamp ==
TxnWrite.NO_TIMESTAMP ? timestamp : overrideTimestamp,
Review Comment:
I added a test to show this. when you do multiple rows and have a
"operator" that happens *after* a read, we used the wrong timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
