dcapwell commented on code in PR #4322:
URL: https://github.com/apache/cassandra/pull/4322#discussion_r2286228208
##########
src/java/org/apache/cassandra/service/accord/txn/TxnWrite.java:
##########
@@ -362,6 +368,9 @@ public void serialize(Fragment fragment, TableMetadatas
tables, DataOutputPlus o
out.writeUnsignedVInt32(fragment.index);
PartitionUpdate.serializer.serializeWithoutKey(fragment.baseUpdate, tables,
out, version.messageVersion());
TxnReferenceOperations.serializer.serialize(fragment.referenceOps, tables, out,
version);
+ out.writeBoolean(fragment.timestamp != NO_TIMESTAMP);
Review Comment:
```
public static void main(String[] args)
{
System.out.println("undefined:");
System.out.println(TypeSizes.sizeofVInt(0));
System.out.println("Current time:");
System.out.println(TypeSizes.sizeofVInt(TimeUnit.MILLISECONDS.toMicros(System.currentTimeMillis())));
}```
```undefined:
1
Current time:
8```
Does save 1 byte
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
