sklaha commented on code in PR #249: URL: https://github.com/apache/cassandra-sidecar/pull/249#discussion_r2291643236
########## adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/jmx/CounterMetricsJmxOperations.java: ########## @@ -21,16 +21,8 @@ /** * An interface that pulls methods from the Cassandra Metrics Proxy */ -public interface MetricsJmxOperations +public interface CounterMetricsJmxOperations Review Comment: Without the separation, there is a risk of someone accidentally calling getCount() on GaugeMetrics or getValue() on CounterMetrics etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
