sklaha commented on PR #249: URL: https://github.com/apache/cassandra-sidecar/pull/249#issuecomment-3226532568
> In general, the Cassandra projects prefer `public final` members over `getters` to reduce boilerplate. It would be nice if you can apply the change to your patch, although I am not strongly against what you already have. If interested, check out https://cassandra.apache.org/_/development/code_style.html for code style guide details. Thanks for the link @yifan-c . Most of the classes in `org.apache.cassandra.sidecar.common.response` package have the variables as `private final`. Are you sure that we would like to make the variables in the new classes `public final`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
