himanshujindal commented on code in PR #4304:
URL: https://github.com/apache/cassandra/pull/4304#discussion_r2307562174
##########
doc/modules/cassandra/pages/managing/operating/auto_repair.adoc:
##########
@@ -219,6 +219,10 @@ in nodetool repair. General advice is to keep this true.
| repair_retry_backoff | 30s | Backoff time before retrying a repair session.
| repair_task_min_duration | 5s | Minimum duration for the execution of a
single repair task. This prevents the
scheduler from overwhelming the node by scheduling too many repair tasks in a
short period of time.
+| mixed_major_version_repair_enabled | false | Enable/Disable running repairs
on the cluster when there are mixed
+major versions detected, which usually occurs when the cluster is being
upgraded. Repairs between nodes of
+different major versions is not something that is tested, so this may lead to
data compatibility issues.
+It is strongly discouraged to set this to true without doing extensive testing
beforehand.
Review Comment:
Good catch. These should be top level settings and not auto repair settings.
Fixed.
##########
src/java/org/apache/cassandra/tools/nodetool/SetAutoRepairConfig.java:
##########
@@ -176,6 +176,9 @@ public void execute(NodeProbe probe)
case "repair_retry_backoff":
probe.setAutoRepairRetryBackoff(repairTypeStr, paramVal);
break;
+ case "mixed_major_version_repair_enabled":
Review Comment:
Good catch. These should be top level settings and not auto repair settings.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
