himanshujindal commented on code in PR #4304:
URL: https://github.com/apache/cassandra/pull/4304#discussion_r2314240069
##########
src/java/org/apache/cassandra/repair/autorepair/AutoRepair.java:
##########
@@ -165,6 +166,11 @@ public void repair(AutoRepairConfig.RepairType repairType)
logger.debug("Auto-repair is disabled for repair type {}",
repairType);
return;
}
+ if (!DatabaseDescriptor.getMixedMajorVersionRepairEnabled() &&
+ Gossiper.instance.hasMultipleLiveMajorVersions()) {
+ logger.info("Auto-repair is disabled when nodes in the cluster
have different major versions");
Review Comment:
@jaydeepkumar1984 See my comment here -
https://github.com/apache/cassandra/pull/4304#issuecomment-3226130821 and
Andy's reply in slack -
https://the-asf.slack.com/archives/C06MR8K2Q0Z/p1756306978752409?thread_ts=1755038748.234549&cid=C06MR8K2Q0Z
We decided not to add a metric since logging should be sufficient here.
Having said that, I will be open to adding a metric if you align with my
proposal presented in the comment linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
