absurdfarce commented on code in PR #2037:
URL:
https://github.com/apache/cassandra-java-driver/pull/2037#discussion_r2319357953
##########
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##########
@@ -47,21 +47,22 @@ default void onSuccess(
@NonNull Node node) {}
/**
- * Invoked each time a request succeeds.
+ * Invoked each time a session request succeeds. A session request is a
`session.execute()` call
*
* @param latencyNanos the overall execution time (from the {@link
Session#execute(Request,
* GenericType) session.execute} call until the result is made available
to the client).
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
- * @param requestLogPrefix the dedicated log prefix for this request
+ * @param sessionRequestLogPrefix the dedicated log prefix for this request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
- // If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
+ @NonNull String sessionRequestLogPrefix) {
+ // If client doesn't override onSuccess with sessionRequestLogPrefix
delegate call to the old
Review Comment:
Are you thinking we should remove it because it's obvious from the code
@lukasz-antoniak? 'Cause, I mean... the code _does_ still do exactly what this
comment says.
It's _debatable_ that this comment is somewhat useful to describe the
general policy setup by this class, by which I mean if you don't override the
version that's aware of the prefix we just fall back on the more general
behaviour. Even in that case there's a decent argument that that can be more
clearly communicated by a comment at the top of the file rather than by
comments on each individual occurrence like we're doing now. I don't feel
super-strongly about it but if you're arguing for something like that I think I
could get on board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
