absurdfarce commented on code in PR #2037:
URL:
https://github.com/apache/cassandra-java-driver/pull/2037#discussion_r2329101461
##########
core/src/main/java/com/datastax/oss/driver/internal/core/cql/CqlRequestHandler.java:
##########
@@ -139,7 +142,11 @@ protected CqlRequestHandler(
String sessionLogPrefix) {
this.startTimeNanos = System.nanoTime();
- this.logPrefix = sessionLogPrefix + "|" + this.hashCode();
+ this.requestIdGenerator = context.getRequestIdGenerator();
Review Comment:
To rephrase the answer from @SiyaoIsHiding just a bit... this gets to the
point I was making about distinguishing between log prefix and the request ID
generator. They aren't the same thing. They don't do the same thing. We
_always_ need a log prefix. But we aren't required to have a request ID
generator. Trying to model log prefix as a request ID generator in all cases
confuses those two roles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
