SiyaoIsHiding commented on code in PR #2037:
URL:
https://github.com/apache/cassandra-java-driver/pull/2037#discussion_r2356064067
##########
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java:
##########
@@ -861,6 +874,12 @@ protected final CompletionStage<CqlSession>
buildDefaultSessionAsync() {
List<String> configContactPoints =
defaultConfig.getStringList(DefaultDriverOption.CONTACT_POINTS,
Collections.emptyList());
if (cloudConfigInputStream != null) {
+ // override request id generator, unless user has already set it
+ if (programmaticArguments.getRequestIdGenerator() == null) {
+ programmaticArgumentsBuilder.withRequestIdGenerator(new
W3CContextRequestIdGenerator());
+ LOG.debug(
+ "A secure connect bundle is provided, using
W3CContextRequestIdGenerator as request ID generator.");
Review Comment:
@absurdfarce the meeting today agreed that Astra will use `traceparent` as
the key. We should change the default key for Astra to `traceparent`. It is
`request-id` right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
