absurdfarce commented on code in PR #2037:
URL:
https://github.com/apache/cassandra-java-driver/pull/2037#discussion_r2337897994
##########
core/src/main/java/com/datastax/oss/driver/internal/core/cql/CqlRequestHandler.java:
##########
@@ -139,7 +142,11 @@ protected CqlRequestHandler(
String sessionLogPrefix) {
this.startTimeNanos = System.nanoTime();
- this.logPrefix = sessionLogPrefix + "|" + this.hashCode();
+ this.requestIdGenerator = context.getRequestIdGenerator();
Review Comment:
I think this conversation is largely resolved now. This code pretty clearly
demonstrates that the simple use of the Optional type allows us to handle the
default case in a more concise way. If anybody disagrees let's discuss further
but given the current contents of the PR my inclination is to resolve this
conversation as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
