netudima commented on PR #4324:
URL: https://github.com/apache/cassandra/pull/4324#issuecomment-3338190547
I see, I've missed that you've already overridden getCount logic in some
branches of the hierarchy. The current trunk state:
```mermaid
graph TD;
CassandraHistogram --> com.codahale.metrics.Histogram
ClearableHistogram --> CassandraHistogram;
OverrideHistogram --> CassandraHistogram;
ShardedHistogram --> OverrideHistogram;
OnDemandHistogram --> OverrideHistogram;
```
Did I get correctly what you suggest the following hierarchy? (where
`Histogram` interface is merged into `CassandraHistogram` class and not present
anymore as a separate interface)
```mermaid
graph TD;
CassandraHistogram --> com.codahale.metrics.Histogram;
ThreadLocalHistogram --> OverrideHistogram;
ClearableHistogram --> ThreadLocalHistogram;
OverrideHistogram --> CassandraHistogram;
ShardedHistogram --> ThreadLocalHistogram;
OnDemandHistogram --> OverrideHistogram;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
