smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2436186929
##########
pylib/cqlshlib/test/test_cqlsh_completion.py:
##########
@@ -1053,7 +1053,7 @@ def test_complete_in_create_index(self):
self.trycompletions('CREATE INDEX example ', immediate='ON ')
def test_complete_in_drop_index(self):
- self.trycompletions('DROP IN', immediate='DEX ')
+ self.trycompletions('DROP I', immediate='NDEX ')
Review Comment:
What do these changes have in common with this CEP? Same above, removed
IDENTITY and ADD
##########
pylib/cqlshlib/test/test_cqlsh_completion.py:
##########
@@ -1212,38 +1212,6 @@ def test_complete_in_create_user(self):
def test_complete_in_drop_role(self):
self.trycompletions('DROP ROLE ', choices=['<identifier>', 'IF',
'<quotedName>'])
- # IDENTITY checks
Review Comment:
why removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
