smiklosovic commented on code in PR #4399: URL: https://github.com/apache/cassandra/pull/4399#discussion_r2410306927
########## conf/cassandra.yaml: ########## @@ -617,6 +617,54 @@ counter_cache_save_period: 7200s # Disabled by default, meaning all keys are going to be saved # counter_cache_keys_to_save: 100 +# Dictionary compression settings for ZSTD dictionary-based compression Review Comment: I am also not completely sure this is the right section of the yaml to put all of this in. Wondering based on what it was put here. Not saying it is wrong, just saying that this is probably the opportunity to be more thoughtful and intentional about where we put it. Given this is probably experimental feature we might also consider to put it among experimental ones at the end of the yaml? Just shooting thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
