rustyrazorblade commented on code in PR #4399: URL: https://github.com/apache/cassandra/pull/4399#discussion_r2424796868
########## src/java/org/apache/cassandra/db/compression/ManualTrainingOptions.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.compression; + +import java.util.Map; + +/** + * Configuration options for manual compression dictionary training. + * This class encapsulates the parsed and validated parameters needed for training. + */ +public class ManualTrainingOptions +{ + private final int maxSamplingDurationSeconds; + + public ManualTrainingOptions(int maxSamplingDurationSeconds) + { + if (maxSamplingDurationSeconds <= 0) + { + throw new IllegalArgumentException("maxSamplingDurationSeconds must be positive, got: " + maxSamplingDurationSeconds); + } + this.maxSamplingDurationSeconds = maxSamplingDurationSeconds; + } + + /** + * Parse options from a string map, typically from JMX/MBean calls. + * + * @param options the string map containing training options + * @return parsed and validated ManualTrainingOptions + * @throws IllegalArgumentException if required parameters are missing or invalid + */ + public static ManualTrainingOptions fromStringMap(Map<String, String> options) + { + if (options == null || !options.containsKey("maxSamplingDurationSeconds")) + { + throw new IllegalArgumentException("maxSamplingDurationSeconds parameter is required for manual dictionary training"); Review Comment: I think the priority should be reducing the number of operator headaches. If it runs for 6 hours, would most people want it to keep running or fail? I'd rather it keep going. What is the benefit of failing, ever? What is the problem if it takes a full week? > I acknowledge that having a failed training after 10 minutes is frustrating. It is up to operators to configure the tool properly; I think we have a responsibility not to ship foot-guns. Defaults should work well. Expecting people to change every config under the guise of "operator responsibility" is a mindset that caused Cassandra to ship some pretty awful defaults for years - GC being a notable example. It's done a lot of damage to the project, and I see it as an abdication of an important responsibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
