bbotella commented on code in PR #4408: URL: https://github.com/apache/cassandra/pull/4408#discussion_r2402227380
########## pylib/cqlshlib/test/test_identity_mappings_completion.py: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from .test_cqlsh_completion import CqlshCompletionCase + + +class TestIdentityMappingsCompletion(CqlshCompletionCase): + + """ + Autcomplete Tests for ADD and DROP Identity Mappings for @cql3handling.py + """ + + def test_identity_autocomplete_add(self): + self.trycompletions('ADD I', immediate='DENTITY ') + + def test_exists_autocomplete_add(self): + self.trycompletions('ADD IDENTITY IF ', immediate='NOT EXISTS ') + self.trycompletions('ADD IDENTITY IF NOT ', immediate='EXISTS ') + + def test_expect_str_literal_autocomplete_add(self): + self.trycompletions('ADD IDENTITY ', + choices=['<pgStringLiteral>', '<quotedStringLiteral>', 'IF']) Review Comment: ``` self.trycompletions('ADD IDENTITY IF NOT EXISTS', choices=['<pgStringLiteral>', '<quotedStringLiteral>']) ``` ? ########## pylib/cqlshlib/test/test_identity_mappings_completion.py: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from .test_cqlsh_completion import CqlshCompletionCase + + +class TestIdentityMappingsCompletion(CqlshCompletionCase): + + """ + Autcomplete Tests for ADD and DROP Identity Mappings for @cql3handling.py + """ + + def test_identity_autocomplete_add(self): + self.trycompletions('ADD I', immediate='DENTITY ') + + def test_exists_autocomplete_add(self): + self.trycompletions('ADD IDENTITY IF ', immediate='NOT EXISTS ') + self.trycompletions('ADD IDENTITY IF NOT ', immediate='EXISTS ') + + def test_expect_str_literal_autocomplete_add(self): + self.trycompletions('ADD IDENTITY ', + choices=['<pgStringLiteral>', '<quotedStringLiteral>', 'IF']) + + def test_TO_autocomplete_add(self): + self.trycompletions("ADD IDENTITY '[email protected]' ", immediate='TO ROLE ') + self.trycompletions("ADD IDENTITY '[email protected]' T", immediate='O ROLE ') + + def test_role_autocomplete_add(self): + self.trycompletions("ADD IDENTITY '[email protected]' TO ", immediate='ROLE ') + self.trycompletions("ADD IDENTITY '[email protected]' TO R", immediate='OLE ') + + def test_rolename_autocomplete_add(self): + self.trycompletions("ADD IDENTITY '[email protected]' TO ROLE ", + choices=['<identifier>', '<quotedName>'], + other_choices_ok=True) + + def test_complete_user_full_statement_add(self): + self.trycompletions("ADD IDENTITY IF NOT EXISTS '[email protected]' TO ROLE data_engineer ", + choices=[';']) + + def test_autocomplete_drop(self): + self.trycompletions('DROP ', Review Comment: Hah! This is the same we are testing here https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/test/test_cqlsh_completion.py#L615-L618 I wonder then why that one is not failing. I think we should consolidate those. ########## pylib/cqlshlib/test/test_identity_mappings_completion.py: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from .test_cqlsh_completion import CqlshCompletionCase + + +class TestIdentityMappingsCompletion(CqlshCompletionCase): + + """ + Autcomplete Tests for ADD and DROP Identity Mappings for @cql3handling.py + """ + + def test_identity_autocomplete_add(self): + self.trycompletions('ADD I', immediate='DENTITY ') + + def test_exists_autocomplete_add(self): + self.trycompletions('ADD IDENTITY IF ', immediate='NOT EXISTS ') + self.trycompletions('ADD IDENTITY IF NOT ', immediate='EXISTS ') + + def test_expect_str_literal_autocomplete_add(self): + self.trycompletions('ADD IDENTITY ', + choices=['<pgStringLiteral>', '<quotedStringLiteral>', 'IF']) + + def test_TO_autocomplete_add(self): + self.trycompletions("ADD IDENTITY '[email protected]' ", immediate='TO ROLE ') + self.trycompletions("ADD IDENTITY '[email protected]' T", immediate='O ROLE ') + + def test_role_autocomplete_add(self): + self.trycompletions("ADD IDENTITY '[email protected]' TO ", immediate='ROLE ') + self.trycompletions("ADD IDENTITY '[email protected]' TO R", immediate='OLE ') + + def test_rolename_autocomplete_add(self): + self.trycompletions("ADD IDENTITY '[email protected]' TO ROLE ", + choices=['<identifier>', '<quotedName>'], + other_choices_ok=True) + + def test_complete_user_full_statement_add(self): + self.trycompletions("ADD IDENTITY IF NOT EXISTS '[email protected]' TO ROLE data_engineer ", Review Comment: Test the same without "IF NOT EXISTS" maybe? ########## pylib/cqlshlib/test/test_identity_mappings_completion.py: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from .test_cqlsh_completion import CqlshCompletionCase + + +class TestIdentityMappingsCompletion(CqlshCompletionCase): Review Comment: While I like the fact that we are splitting it into a new test file, I see that the pattern is to have them all consolidated in `test_cqlsh_completion.py` (that would have helped catching the DROP completion test duplication). I think we should add these tests there to follow the existing pattern, and maybe start a conversation on the dev slack (or Mailing list?) about splitting the completion tests (right now, a python file of 1242 lines and counting). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
