frankgh commented on code in PR #4408: URL: https://github.com/apache/cassandra/pull/4408#discussion_r2403044365
########## pylib/cqlshlib/test/test_identity_mappings_completion.py: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from .test_cqlsh_completion import CqlshCompletionCase + + +class TestIdentityMappingsCompletion(CqlshCompletionCase): Review Comment: I agree here with Bernardo. We should probably try to consolidate the testing logic in `test_cqlsh_completion.py`. I think some existing autocompletion test scenarios will fail in `test_cqlsh_completion.py`. I don't think we need a mailing list discussion for this change, I think it's pretty straightforward to make the change in `test_cqlsh_completion.py`, and we shouldn't really think too much about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
