smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2436520572


##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -614,6 +630,7 @@ public static class Serializer implements 
MetadataSerializer<TableParams>
         public void serialize(TableParams t, DataOutputPlus out, Version 
version) throws IOException
         {
             out.writeUTF(t.comment);
+            out.writeUTF(t.securityLabel);

Review Comment:
   I do not think we can do this. You should move this to the very end of this 
method and do version check.



##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -649,6 +666,7 @@ public TableParams deserialize(DataInputPlus in, Version 
version) throws IOExcep
         {
             TableParams.Builder builder = TableParams.builder();
             builder.comment(in.readUTF())
+                   .securityLabel(in.readUTF())

Review Comment:
   I do not think we can do this. You should move this to the very end of this 
method and do version check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to