smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2436500207
##########
src/java/org/apache/cassandra/schema/KeyspaceParams.java:
##########
@@ -69,17 +71,26 @@ public String toString()
public final boolean durableWrites;
public final ReplicationParams replication;
public final FastPathStrategy fastPath;
+ public final String comment;
+ public final String securityLabel;
public KeyspaceParams(boolean durableWrites, ReplicationParams
replication, FastPathStrategy fastPath)
+ {
+ this(durableWrites, replication, fastPath, "", "");
Review Comment:
so what is it, empty string or null? Because `ColumnMetadata` have
`@Nullable` on parameters in a contructor. I suspect that the usage of this is
not consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
