yifan-c commented on code in PR #4399:
URL: https://github.com/apache/cassandra/pull/4399#discussion_r2437718619
##########
src/java/org/apache/cassandra/utils/StorageCompatibilityMode.java:
##########
@@ -35,6 +35,13 @@ public enum StorageCompatibilityMode
*/
CASSANDRA_4(4),
+ /**
+ * Similar to CASSANDRA_4.
+ * The new features in 6.0 are
+ * - ZSTD dictionary-based compression. Once SSTables are compressed with
dictionary, they cannot be rolled back.
+ */
+ CASSANDRA_5(5),
+
Review Comment:
Is it necessary? `StorageCompatibilityMode` is to check the sstable format
compatibility, which is not changed in this patch. Also, the dictionary feature
is opt-in. I'd incline removing the code. It seems unnecessary.
cc: @smiklosovic , @rustyrazorblade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
