smiklosovic commented on code in PR #4399:
URL: https://github.com/apache/cassandra/pull/4399#discussion_r2410382840
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -1796,6 +1796,7 @@ public static SSTableWriter
createWriter(ColumnFamilyStore cfs,
.setSerializationHeader(sstable.header)
.addDefaultComponents(cfs.indexManager.listIndexGroups())
.setSecondaryIndexGroups(cfs.indexManager.listIndexGroups())
+
.setCompressionDictionaryManager(cfs.compressionDictionaryManager())
Review Comment:
closing anywhere?
##########
src/java/org/apache/cassandra/db/compaction/unified/ShardedMultiWriter.java:
##########
@@ -118,6 +118,7 @@ private SSTableWriter createWriter(Descriptor descriptor)
.setSerializationHeader(header)
.addDefaultComponents(indexGroups)
.setSecondaryIndexGroups(indexGroups)
+
.setCompressionDictionaryManager(cfs.compressionDictionaryManager())
Review Comment:
who is "closing" this manager? Not so far in the review to figure it out on
my own ... This is highlighted in IDEA as something we do not use
try-with-resources on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
