smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2436525316


##########
src/java/org/apache/cassandra/tcm/serialization/Version.java:
##########
@@ -68,6 +68,8 @@ public enum Version
      */
     V7(7),
 
+    V8(8),

Review Comment:
   add a comment which says what was introduced by this version, same as for 
other versions above



##########
src/resources/org/apache/cassandra/cql3/reserved_keywords.txt:
##########
@@ -8,14 +8,17 @@ AUTHORIZE
 BATCH
 BEGIN
 BY
+COLUMN
 COLUMNFAMILY
+COMMENTS

Review Comment:
   I dont get these plurals



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to