worryg0d commented on code in PR #1926:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1926#discussion_r2727044502
##########
events.go:
##########
@@ -133,40 +133,40 @@ func (s *Session) handleEvent(framer *framer) {
}
func (s *Session) handleSchemaEvent(frames []frame) {
- type keyspaceChange struct {
- keyspace string
- change string
+
+ if len(frames) > 0 {
+ s.control.awaitSchemaAgreement()
}
Review Comment:
nit: Just thinking if it really makes sense to return from this if
len(frame) < 1, so we prevent allocation of a keyspacesToRefresh map. I'm
unsure if go compiler optimizes this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
