joao-r-reis commented on code in PR #1926:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1926#discussion_r2747086214
##########
metadata.go:
##########
@@ -519,6 +551,39 @@ func getKeyspaceMetadata(session *Session, keyspaceName
string) (*KeyspaceMetada
return keyspace, nil
}
+// getAllKeyspaceNames queries system tables for all keyspace names.
+func getAllKeyspaceNames(session *Session) ([]string, error) {
Review Comment:
Hmm honestly we shouldn't break support of C* 2.x if we don't have a good
reason because C* 2.2 still supports v3 and v4 which the driver supports but it
is true that since we don't have it on our CI it's hard to tell if we even
still support it right now. We removed v2 protocol support because to find a C*
version that didn't support at least v3 we had to go back to 2.0.x which is
very very old but 2.1.x and 2.2.x support v3 (and v4 in the 2.2.x case) so it
was a bit different in my view.
If someone opens a bug mentioning that C* 2.2 or 2.1 support is broken on
the driver I'd be in favor of fixing the bug even if we don't provide full
support by including it in our CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
