dcapwell commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2729644308
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -583,6 +583,10 @@ public static class SSTableConfig
public volatile int tombstone_warn_threshold = 1000;
public volatile int tombstone_failure_threshold = 100000;
+ public volatile boolean write_thresholds_enabled = false;
+ public volatile DataStorageSpec.LongBytesBound write_size_warn_threshold =
null;
+ public volatile int write_tombstone_warn_threshold = -1;
Review Comment:
> OR >= 0
thats actually a bug we block in guardrails =)
> I think it will be a redundant validation if I add soemthing similar to
read thresholds, what do you think ?
`write_tombstone_warn_threshold: -42` is a bug and must be rejected. The
spec is `-1` disabled and `0+` for valid values. If the user does anything
else they should be informed that its unexpected behavior.
Our public API should be strict and not reflect implementation details. The
fact our code does `>= 0` doesn't really matter, its what we *allow* the user's
to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
