dcapwell commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2729702848
##########
src/java/org/apache/cassandra/service/WriteResponseHandler.java:
##########
@@ -58,12 +61,17 @@ public WriteResponseHandler(ReplicaPlan.ForWrite
replicaPlan, WriteType writeTyp
public void onResponse(Message<T> m)
{
+ if (m != null)
+ {
+ Map<ParamType, Object> params = m.header.params();
+ if (WriteWarningContext.isSupported(params.keySet()))
+ {
+ getWarningContext().updateCounters(params, m.from());
+ }
+ }
replicaPlan.collectSuccess(m == null ?
FBUtilities.getBroadcastAddressAndPort() : m.from());
if (responsesUpdater.decrementAndGet(this) == 0)
signal();
- //Must be last after all subclass processing
- //The two current subclasses both assume logResponseToIdealCLDelegate
is called
- //here.
Review Comment:
why did you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
