smiklosovic commented on code in PR #4557:
URL: https://github.com/apache/cassandra/pull/4557#discussion_r2731490896
##########
src/java/org/apache/cassandra/service/StartupChecks.java:
##########
@@ -150,12 +132,65 @@ public enum StartupCheckType
checkKernelParamsForAsyncProfiler,
new
DataResurrectionCheck());
+ public List<StartupCheck> getChecks()
+ {
+ return preFlightChecks;
+ }
+
+ public StartupCheck getCheck(String name)
+ {
+ for (StartupCheck startupCheck : preFlightChecks)
+ {
+ if (startupCheck.name().equals(name))
+ return startupCheck;
+ }
Review Comment:
I would prefer not to do this. I consider it to be a premature optimisation.
Keep in mind that we are iterating over this effectively just once when a node
starts and then never again. It would require more work that this patch is
about too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
