smiklosovic commented on code in PR #4557:
URL: https://github.com/apache/cassandra/pull/4557#discussion_r2731501933
##########
src/java/org/apache/cassandra/service/StartupChecks.java:
##########
@@ -150,12 +132,65 @@ public enum StartupCheckType
checkKernelParamsForAsyncProfiler,
new
DataResurrectionCheck());
+ public List<StartupCheck> getChecks()
+ {
+ return preFlightChecks;
+ }
+
+ public StartupCheck getCheck(String name)
+ {
+ for (StartupCheck startupCheck : preFlightChecks)
+ {
+ if (startupCheck.name().equals(name))
+ return startupCheck;
+ }
+ return null;
+ }
+
public StartupChecks withDefaultTests()
{
preFlightChecks.addAll(DEFAULT_TESTS);
Review Comment:
I think that's an overkill. `DEFAULT_TESTS` are populated by developers by
updating that list. Also checks should be idempotent in their execution so even
if they are run multiple times nothing should happen, otherwise that check
would have side-effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
