aparna0522 commented on code in PR #4569:
URL: https://github.com/apache/cassandra/pull/4569#discussion_r2738301426


##########
src/java/org/apache/cassandra/replication/CoordinatorLog.java:
##########
@@ -283,6 +283,24 @@ Offsets.Immutable collectReconciledOffsets()
         }
     }
 
+    /**
+     * Returns the UNION of all witnessed offsets from all participants.
+     * This represents all offsets that ANY replica has witnessed.
+     */
+    Offsets.Immutable collectUnionOfWitnessedOffsets()

Review Comment:
   Discussed with Blake: We are currently planning to go with just listening to 
what offsets the other nodes are broadcasting starting after the IR starts, 
i.e. broadcasts that happen every 200ms. We might change our approach if it 
turns out to be an issue later. 
   
   Also, as Blake stated:
   > waiting a few seconds for incremental repair to start and a few more for 
it to complete is totally within the realm of reasonable for a repair process



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to