aparna0522 commented on code in PR #4569:
URL: https://github.com/apache/cassandra/pull/4569#discussion_r2743627210
##########
src/java/org/apache/cassandra/replication/CoordinatorLog.java:
##########
@@ -283,6 +283,24 @@ Offsets.Immutable collectReconciledOffsets()
}
}
+ /**
+ * Returns the UNION of all witnessed offsets from all participants.
+ * This represents all offsets that ANY replica has witnessed.
+ */
+ Offsets.Immutable collectUnionOfWitnessedOffsets()
Review Comment:
Umm, yea for that, I have added a timeout of 10s - if we don't receive the
broadcast within that time we continue towards completing the repair. This is a
buffer for about 50 broadcast cycles - do you think this is sufficient?
Do you think we should not move forward instead of completing the repair?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
