maedhroz commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2756000652
##########
src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java:
##########
@@ -1008,8 +1033,9 @@ private UnfilteredRowIterator
queryMemtableAndSSTablesInTimestampOrder(ColumnFam
{
if (iter.isEmpty())
continue;
-
- result = add(RTBoundValidator.validate(iter,
RTBoundValidator.Stage.SSTABLE, false),
+ UnfilteredRowIterator wrapped = rowTransformer != null ?
Transformation.apply(iter, rowTransformer.apply(sstable.getId()))
+ : iter;
+ result = add(RTBoundValidator.validate(wrapped,
RTBoundValidator.Stage.SSTABLE, false),
Review Comment:
Had a chance to look at this again, and the logic should be unchanged if the
transformer is `null`. The only thing I think might be helpful is to have a
marker interface, let's say we call it `RowSourceIdentifier` that `Memtable`
and `SSTableId` can implement (perhaps w/ an `equals()` method in the interface
just to make it clear that we need that, even though `Memtable` implementations
all use reference equality).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
