michaeljmarshall commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2849776088
##########
src/java/org/apache/cassandra/index/sai/view/IndexViewManager.java:
##########
@@ -186,6 +179,13 @@ private Pair<Collection<SSTableIndex>,
Collection<SSTableContext>> getBuiltIndex
}
SSTableIndex ssTableIndex =
sstableContext.newSSTableIndex(index);
+ if (ssTableIndex == null)
+ {
+ logger.debug(index.identifier().logMessage("No on-disk
index was built for SSTable {} because the SSTable " +
+ "had no
indexable rows for the index."), sstableContext.descriptor());
+ continue;
+ }
Review Comment:
I think this concern was taken care of via this commit
https://github.com/michaeljmarshall/cassandra/commit/7e550ccfd1a330bd15e43a941bdbccbf3bb2c52f
(which is now squashed but is preserved on my "pre-squash" branch in my own
fork). Please resolve if you agree.
Note that we ran into several edge cases where we ultimately filter out
these empty index objects, but for now, we keep them in the `view` so that the
view can be considered complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
